Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Search landing page] Update search landing page list with new links #194656

Merged
merged 13 commits into from
Oct 10, 2024

Conversation

kosabogi
Copy link
Contributor

@kosabogi kosabogi commented Oct 2, 2024

Overview

This PR updates the search landing page by refreshing the existing list with new links.

Related issue

https://github.com/elastic/search-docs-team/issues/200

@kosabogi kosabogi added Team:Docs release_note:skip Skip the PR/issue when compiling release notes v9.0.0 v8.16.0 backport:version Backport to applied version labels labels Oct 2, 2024
@kosabogi kosabogi requested a review from leemthompo October 2, 2024 06:24
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-docs (Team:Docs)

Copy link
Contributor

github-actions bot commented Oct 2, 2024

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

Copy link
Contributor

@leemthompo leemthompo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few syntax issues here + plus some edits based on information that you would have no way of knowing 😄

docs/search/index.asciidoc Outdated Show resolved Hide resolved
docs/search/index.asciidoc Outdated Show resolved Hide resolved
docs/search/index.asciidoc Outdated Show resolved Hide resolved
docs/search/index.asciidoc Outdated Show resolved Hide resolved
// | link:https://example.com/connectors/docs[Documentation]
// | link:https://example.com/connectors/notes[Release notes]
| Connectors
| link:https://www.elastic.co/guide/en/elasticsearch/reference/8.15/connector-apis.html[API reference]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| link:https://www.elastic.co/guide/en/elasticsearch/reference/8.15/connector-apis.html[API reference]
| {ref}/connector-apis.html[API reference]

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@leemthompo leemthompo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @kosabogi 🚀

@kosabogi kosabogi merged commit 7a30154 into elastic:main Oct 10, 2024
8 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11271257765

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 10, 2024
…lastic#194656)

### Overview

This PR updates the search landing page by refreshing the existing list
with new links.

### Related issue

elastic/search-docs-team#200

---------

Co-authored-by: Liam Thompson <[email protected]>
(cherry picked from commit 7a30154)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 10, 2024
…links (#194656) (#195729)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Search landing page] Update search landing page list with new links
(#194656)](#194656)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"kosabogi","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-10T09:27:03Z","message":"[Search
landing page] Update search landing page list with new links
(#194656)\n\n### Overview\r\n\r\nThis PR updates the search landing page
by refreshing the existing list\r\nwith new links.\r\n\r\n### Related
issue\r\n\r\nhttps://github.com/elastic/search-docs-team/issues/200\r\n\r\n---------\r\n\r\nCo-authored-by:
Liam Thompson
<[email protected]>","sha":"7a30154fdfc109a87b69d429bb2252cf5499d5b9","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Docs","release_note:skip","v9.0.0","v8.16.0","backport:version"],"title":"[Search
landing page] Update search landing page list with new
links","number":194656,"url":"https://github.com/elastic/kibana/pull/194656","mergeCommit":{"message":"[Search
landing page] Update search landing page list with new links
(#194656)\n\n### Overview\r\n\r\nThis PR updates the search landing page
by refreshing the existing list\r\nwith new links.\r\n\r\n### Related
issue\r\n\r\nhttps://github.com/elastic/search-docs-team/issues/200\r\n\r\n---------\r\n\r\nCo-authored-by:
Liam Thompson
<[email protected]>","sha":"7a30154fdfc109a87b69d429bb2252cf5499d5b9"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/194656","number":194656,"mergeCommit":{"message":"[Search
landing page] Update search landing page list with new links
(#194656)\n\n### Overview\r\n\r\nThis PR updates the search landing page
by refreshing the existing list\r\nwith new links.\r\n\r\n### Related
issue\r\n\r\nhttps://github.com/elastic/search-docs-team/issues/200\r\n\r\n---------\r\n\r\nCo-authored-by:
Liam Thompson
<[email protected]>","sha":"7a30154fdfc109a87b69d429bb2252cf5499d5b9"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: kosabogi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes Team:Docs v8.16.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants